Changeset 46d6469 in network-game

Timestamp:

Jul 26, 2013, 6:28:39 PM (11 years ago)

Author:

dportnoy <dmp1488@…>

Branches:

master

Children:

9fe1807

Parents:

411c1ae

Message:

Some bug fixes for MessageProcessor. MessageContainer is now in its own files.

Files:

• common/MessageContainer.cpp (added)
• common/MessageContainer.h (added)
• common/MessageProcessor.cpp (modified) (6 diffs)
• common/MessageProcessor.h (modified) (2 diffs)
• server/makefile (modified) (2 diffs)

common/MessageProcessor.cpp

@@ -13 +13 @@
 
 int MessageProcessor::sendMessage(NETWORK_MSG *msg, int sock, struct sockaddr_in *dest) {
+   cout << "Sending message of type " << msg->type << endl;
+
    msg->id = ++lastUsedId;
    MessageContainer message(*msg, *dest);
    sentMessages[msg->id][dest->sin_addr.s_addr] = message;
 
-   cout << "Sending message" << endl;
-   cout << "id: " << msg->id << endl;
-   cout << "type: " << msg->type << endl;
-   cout << "buffer: " << msg->buffer << endl;
+   sentMessages[msg->id][dest->sin_addr.s_addr] = message;
 
    int ret =  sendto(sock, (char*)msg, sizeof(NETWORK_MSG), 0, (struct sockaddr *)dest, sizeof(struct sockaddr_in));
-
-   cout << "Send a message of type " << msg->type << endl;
 
    return ret;
@@ -38 +35 @@
       return ret;
 
-   cout << "Received message" << endl;
-
    // add id to the NETWORK_MSG struct
    if (msg->type == MSG_TYPE_ACK) {
-      cout << "Received ack" << endl;
-      if (!sentMessages[msg->id][source->sin_addr.s_addr].isAcked) {
-         cout << "Received new ack" << endl;
-         sentMessages[msg->id][source->sin_addr.s_addr].isAcked = true;
-         sentMessages[msg->id][source->sin_addr.s_addr].timeAcked = getCurrentMillis();
+      if (!sentMessages[msg->id][source->sin_addr.s_addr].getAcked()) {
+         sentMessages[msg->id][source->sin_addr.s_addr].setAcked(true);
+         sentMessages[msg->id][source->sin_addr.s_addr].setTimeAcked(getCurrentMillis());
       }
 
@@ -52 +45 @@
    }else {
       bool isDuplicate = false;
-
-      cout << "Received real message" << endl;
-      cout << "id: " << msg->id << endl;
-      cout << "type: " << msg->type << endl;
-      cout << "buffer: " << msg->buffer << endl;
 
       if (ackedMessages.find(msg->id) != ackedMessages.end())
@@ -84 +72 @@
       sentMsg = it->second;
       for (it2 = sentMsg.begin(); it2 != sentMsg.end(); it2++) {
-         sendto(sock, (char*)&it2->second.msg, sizeof(NETWORK_MSG), 0, (struct sockaddr *)&it2->first, sizeof(struct sockaddr_in));
+         if (!(it2->second.getAcked())) {
+            sendto(sock, it2->second.getMessage(), sizeof(NETWORK_MSG), 0, (struct sockaddr *)&it2->first, sizeof(struct sockaddr_in));
+         }
       }
    }
@@ -95 +85 @@
    while (it != sentMessages.end()) {
       it2 = it->second.begin();
-      while (it2 != it->second.begin()) {
-         if (it2->second.isAcked) {
-            if ((getCurrentMillis() - it2->second.timeAcked) > 1000)
+      while (it2 != it->second.end()) {
+         if (it2->second.getAcked()) {
+            if ((getCurrentMillis() - it2->second.getTimeAcked()) > 1000)
                it->second.erase(it2++);
             else
@@ -114 +104 @@
 
    while (it3 != ackedMessages.end()) {
-      if ((getCurrentMillis() - it3->second) > 500) {
+      if ((getCurrentMillis() - it3->second) > 500)
          ackedMessages.erase(it3++);
-         cout << "Deleting ack record" << endl;
-      }else
+      else
          it3++;
    }

common/MessageProcessor.h

@@ -4 +4 @@
 #include <map>
 
-#include "Compiler.h"
-
-#if defined WINDOWS
-   #include <winsock2.h>
-   #include <WS2tcpip.h>
-#elif defined LINUX
-   #include <netinet/in.h>
-#endif
-
-#define MSG_TYPE_ACK               1
-#define MSG_TYPE_REGISTER          2
-#define MSG_TYPE_LOGIN             3
-#define MSG_TYPE_LOGOUT            4
-#define MSG_TYPE_CHAT              5
-#define MSG_TYPE_PLAYER            6  // server sends this to update player positions
-#define MSG_TYPE_PLAYER_MOVE       7  // client sends this when a player wants to move
-#define MSG_TYPE_OBJECT            8
-#define MSG_TYPE_REMOVE_OBJECT     9
-#define MSG_TYPE_PICKUP_FLAG       10
-#define MSG_TYPE_DROP_FLAG         11
-#define MSG_TYPE_SCORE             12
-#define MSG_TYPE_START_ATTACK      13
-#define MSG_TYPE_ATTACK            14
-#define MSG_TYPE_PROJECTILE        15
-#define MSG_TYPE_REMOVE_PROJECTILE 16
-
-typedef struct
-{
-   unsigned int id;
-   unsigned short type;
-   char buffer[256];
-} NETWORK_MSG;
+#include "MessageContainer.h"
 
 using namespace std;
 
 class MessageProcessor {
+private:
+   int lastUsedId;
+
+   // map from message ids to maps from player addresses to message info
+   map<int, map<unsigned long, MessageContainer> > sentMessages;
+
+   // map from message ids to the time each mesage was acked
+   map<unsigned int, unsigned long long> ackedMessages;
+
+   unsigned long pid;
+
 public:
    MessageProcessor();
@@ -48 +28 @@
    void resendUnackedMessages(int sock);
    void cleanAckedMessages();
-
-private:
-   // this should eventually just replace the Message struct
-   class MessageContainer {
-   public:
-      MessageContainer() {
-      }
-
-      MessageContainer(const MessageContainer& mc) {
-         this->msg = mc.msg;
-         this->clientAddr = mc.clientAddr;
-      }
-
-      MessageContainer(NETWORK_MSG msg, struct sockaddr_in clientAddr) {
-         this->clientAddr = clientAddr;
-         this->msg = msg;
-      }
-
-      ~MessageContainer() {
-      }
-
-      NETWORK_MSG msg;
-      struct sockaddr_in clientAddr;
-      bool isAcked;
-      unsigned long long timeAcked;
-   };
-
-   int lastUsedId;
-
-   // map from message ids to maps from player addresses to message info
-   map<int, map<unsigned long, MessageContainer> > sentMessages;
-
-   // map from message ids to the time each mesage was acked
-   map<unsigned int, unsigned long long> ackedMessages;
 };
 

server/makefile

@@ -3 +3 @@
 FLAGS = $(LIB_FLAGS)
 COMMON_PATH = ../common
-DEPENDENCIES = Common.o MessageProcessor.o Player.o WorldMap.o DataAccess.o Projectile.o
+DEPENDENCIES = Common.o MessageContainer.o MessageProcessor.o Player.o WorldMap.o DataAccess.o Projectile.o
 
 server : server.cpp $(DEPENDENCIES)
@@ -9 +9 @@
 
 Common.o : $(COMMON_PATH)/Common.cpp
+        $(CC) -c -o $@ $?
+
+MessageContainer.o : $(COMMON_PATH)/MessageContainer.cpp
         $(CC) -c -o $@ $?