Changeset 3b84bb6 in opengl-game for graphics-pipeline_vulkan.hpp

Timestamp:

Feb 25, 2020, 6:51:02 PM (5 years ago)

Author:

Dmitry Portnoy <dmitry.portnoy@…>

Branches:

feature/imgui-sdl, master, points-test

Children:

44f23af

Parents:

2da64ef

Message:

In VulkanGame, call centerObject() on all objects when they are created and move that call inside VulkanGame::addObject(), rename GraphicsPipeline_Vulkan::addVertices() to addObject, add start adding generic support for objects to be added after pipeline creation is complete

File:

• graphics-pipeline_vulkan.hpp (modified) (4 diffs)

graphics-pipeline_vulkan.hpp

@@ -71 +71 @@
       void createRenderCommands(VkCommandBuffer& commandBuffer, uint32_t currentImage);
 
-      void addVertices(const vector<VertexType>& vertices, vector<uint16_t> indices, VkCommandPool commandPool,
-         VkQueue graphicsQueue);
+      bool addObject(const vector<VertexType>& vertices, vector<uint16_t> indices, SSBOType& ssbo,
+         VkCommandPool commandPool, VkQueue graphicsQueue);
 
       void updateObject(size_t objIndex, SSBOType& ssbo);
@@ -125 +125 @@
 
 // TODO: Verify that vertex capacity and index capacity are both > 0
+// TODO: See if it would be feasible to move code in the createPipeline method
+// into the constructor. That way, I can also put relevant cleanup code into the destructor
 template<class VertexType, class SSBOType>
 GraphicsPipeline_Vulkan<VertexType, SSBOType>::GraphicsPipeline_Vulkan(
@@ -473 +475 @@
 
 template<class VertexType, class SSBOType>
-void GraphicsPipeline_Vulkan<VertexType, SSBOType>::addVertices(const vector<VertexType>& vertices, vector<uint16_t> indices,
-      VkCommandPool commandPool, VkQueue graphicsQueue) {
+bool GraphicsPipeline_Vulkan<VertexType, SSBOType>::addObject(
+      const vector<VertexType>& vertices, vector<uint16_t> indices,
+      SSBOType& ssbo, VkCommandPool commandPool, VkQueue graphicsQueue) {
+
+   // TODO: When resizing the vertex or index buffer, take deleted objects into account.
+   // Remove their data from the buffer and determine the new size of the bufer based on # of remining objects
+
+   // If # non-deleted objects > currentCapacity / 2
+   //    - resize and double capacity
+   // else If # non-deleted objects < currentCapacity / 4
+   //    - resize amd halve capacity
+   // else
+   //    - don't resize, but rewrite data in the buffer to only have non-deleted objects
 
    if (numVertices + vertices.size() > vertexCapacity) {
@@ -490 +503 @@
       graphicsQueue);
    numIndices += indices.size();
+
+   bool resizedStorageBuffer = false;
+
+   return resizedStorageBuffer;
 }